Merged
Conversation
dhayab
commented
Mar 12, 2026
| "test:e2e": "playwright test", | ||
| "test:e2e:saucelabs": "playwright test", | ||
| "watch:es": "yarn --silent build:es:base --watch" | ||
| "watch:es": "BABEL_ENV=es,rollup BUILD_FORMAT=esm rollup -c rollup.config.mjs --watch" |
Member
Author
There was a problem hiding this comment.
Unrelated to the PR but won't hurt, it fixes watch:es since build:es:base doesn't exist anymore. Let me know if you'd rather I do this in its own PR.
dhayab
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f759bb:
|
sarahdayan
approved these changes
Mar 12, 2026
Member
sarahdayan
left a comment
sarahdayan
left a comment
There was a problem hiding this comment.
LGTM once the bundle size is fixed.
Haroenv
approved these changes
Mar 12, 2026
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
I like that the js prop is called autofocus and the react one autoFocus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
autofocusoption to the autocomplete widget (IS.js) andautoFocusprop (React) that focuses the input and opens the panel on mount.